nastra commented on code in PR #7046:
URL: https://github.com/apache/iceberg/pull/7046#discussion_r1134189875
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -113,26 +115,44 @@ boolean keepTokenRefreshed() {
OAuth2Properties.TOKEN_REFRESH_ENABLED_DEFAULT);
}
+ private ScheduledExecutorService tokenRefreshExecutor() {
Review Comment:
right, we can make the method static if we move `keepTokenRefreshed()` out,
but I'd like to keep the logic inside this method (similar to how we have it in
https://github.com/apache/iceberg/blob/fa6fa237ebaa4ac6c4b0c40b117aff22466d2b17/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L485-L487)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
