nastra commented on code in PR #7046:
URL: https://github.com/apache/iceberg/pull/7046#discussion_r1132285302
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -70,10 +69,13 @@
private static final Cache<Key, SignedComponent> SIGNED_COMPONENT_CACHE =
Caffeine.newBuilder().expireAfterWrite(30,
TimeUnit.SECONDS).maximumSize(100).build();
- private static final ScheduledExecutorService TOKEN_REFRESH_EXECUTOR =
- ThreadPools.newScheduledPool("s3-signer-token-refresh", 1);
private static final String SCOPE = "sign";
- private static final AtomicReference<RESTClient> HTTP_CLIENT_REF = new
AtomicReference<>();
+
+ @SuppressWarnings("immutables:incompat")
Review Comment:
this is to suppress `warning: (immutables:incompat) Avoid introduction of
fields (except constants) in abstract value types`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
