rdblue commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1132986383
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCopyOnWriteDelete.java:
##########
@@ -126,7 +130,12 @@ public synchronized void
testDeleteWithConcurrentTableRefresh() throws Exception
for (int numAppends = 0; numAppends < 5; numAppends++) {
DataFile dataFile = writeDataFile(table,
ImmutableList.of(record));
- table.newFastAppend().appendFile(dataFile).commit();
+ AppendFiles appendFiles =
table.newFastAppend().appendFile(dataFile);
+ if (branch != null) {
+ appendFiles.toBranch(branch);
Review Comment:
Looks like appends were updated, but deletes weren't? I think this would
mean that this test would no longer fail for the REST catalog that has
fine-grained checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
