rdblue commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1132984554
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java:
##########
@@ -42,11 +42,12 @@
BaseBatchReader(
Table table,
+ String branch,
Review Comment:
I'm fine passing either the table schema or the branch. I looked into this
as well and I thought that the advantage of passing the branch was that we
preserve all of the information needed whenever we pass table. If we pass table
without the branch then we'll possibly pass a table and a schema that doesn't
match it's current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
