aokolnychyi commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1131949519
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -276,12 +277,13 @@ private ExpireSnapshots.Result
deleteFiles(Iterator<FileInfo> files) {
}
LOG.info("Deleted {} total files", summary.totalFilesCount());
-
- return new BaseExpireSnapshotsActionResult(
- summary.dataFilesCount(),
- summary.positionDeleteFilesCount(),
- summary.equalityDeleteFilesCount(),
- summary.manifestsCount(),
- summary.manifestListsCount());
+ return ImmutableResult.builder()
Review Comment:
I am not familiar with this lib but won't the name conflict if we migrate
more results to auto-generated beans as it does not take the parent class name
into account?
```
import org.apache.iceberg.actions.ImmutableResult;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
