stevenzwu commented on code in PR #7059:
URL: https://github.com/apache/iceberg/pull/7059#discussion_r1131945408
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -69,16 +73,20 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
List<String> equalityColumns =
tableSchema.getPrimaryKey().map(UniqueConstraint::getColumns).orElseGet(ImmutableList::of);
- return (DataStreamSinkProvider)
Review Comment:
I checked Flink code. Flink added a default implementation to the single
abstract method in `DataStreamSinkProvider`. Adding a default implementation
usually is not considered as a breaking change, except for
`FunctionalInterface` in this case. But this class was never annotated with
`@FunctionalInterface`. Maybe we shouldn't have used the lambda function here
at the first place.
We should fix the lambda regardless if we decided to update Flink patch
version for compileOnly deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
