jackye1995 commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1127135316
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -628,6 +630,41 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /** Region to be used by the SigV4 protocol for signing requests. */
+ public static final String REST_SIGNER_REGION = "rest.signing-region";
+
+ /** The service name to be used by the SigV4 protocol for signing requests.
*/
+ public static final String REST_SIGNING_NAME = "rest.signing-name";
+
+ /** The default service name (API Gateway and lambda) used during SigV4
signing. */
Review Comment:
nit: I think this is for API Gateway only? It does not have anything to do
with Lambda.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
