rdblue commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1126894923
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -659,10 +659,7 @@ private Table load(Identifier ident) {
Matcher branch = BRANCH.matcher(ident.name());
if (branch.matches()) {
- Snapshot branchSnapshot = table.snapshot(branch.group(1));
- if (branchSnapshot != null) {
- return new SparkTable(table, branchSnapshot.snapshotId(),
!cacheEnabled);
- }
+ return new SparkTable(table, branch.group(1), !cacheEnabled);
Review Comment:
I think we should start with the strict `branch_` names like this uses. The
`VERSION AS OF` syntax provides a better way in the long term, so we can be
strict for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
