jackye1995 commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1126757454
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java:
##########
@@ -186,11 +189,14 @@ public void testMergeWithStaticPredicatePushDown() {
row(2L, "hardware") // new
);
assertEquals(
- "Output should match", expectedRows, sql("SELECT * FROM %s ORDER BY
id, dep", tableName));
+ "Output should match",
+ expectedRows,
+ sql("SELECT * FROM %s ORDER BY id, dep", selectTarget()));
}
@Test
public void testMergeIntoEmptyTargetInsertAllNonMatchingRows() {
+ Assume.assumeTrue("Branch can only be used for non-empty table", branch ==
null);
Review Comment:
Thanks for the suggestion an verification! Once we can have the experience
discussion settled I will come back to fix this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
