rdblue commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1125760676
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -315,4 +346,14 @@ protected DataFile writeDataFile(Table table,
List<GenericRecord> records) {
throw new UncheckedIOException(e);
}
}
+
+ @Override
+ protected String queryTarget() {
Review Comment:
Very minor: I think `commandTarget()` would be a bit better name because
this is used for the INSERT/DELETE/UPDATE/MERGE commands. MERGE has a target,
but we don't usually refer to an INSERT query's table as a target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
