amogh-jahagirdar commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1121985232
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -659,10 +659,7 @@ private Table load(Identifier ident) {
Matcher branch = BRANCH.matcher(ident.name());
if (branch.matches()) {
- Snapshot branchSnapshot = table.snapshot(branch.group(1));
- if (branchSnapshot != null) {
- return new SparkTable(table, branchSnapshot.snapshotId(),
!cacheEnabled);
- }
+ return new SparkTable(table, branch.group(1), !cacheEnabled);
Review Comment:
Do we want to keep the "branch_" prefix in the identifier? I just removed it
in the previous PR and everything after the table part in the identifier is
treated as a branch.
https://github.com/apache/iceberg/pull/6651/files#diff-6028f80634c027dee9ea947b9f0e50a51b1e5ced1834b902f0f47303514d0e96L660
I'm okay either way one benefit of keeping the prefix is that from a user
experience point of view it's explicit it's a branch and will less likely
collide with column identifier. It's just a bit more verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
