[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6880: Delta Migration: Handle delta lake's automatic log clean and VACUUM

[via GitHub]

jackye1995 commented on code in PR #6880:
URL: https://github.com/apache/iceberg/pull/6880#discussion_r1118994135


##########
delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:
##########
@@ -122,28 +129,36 @@ public TestSnapshotDeltaLakeTable(
 
   @Before
   public void before() throws IOException {
-    File partitionedFolder = temp1.newFolder();
-    File unpartitionedFolder = temp2.newFolder();
-    File newIcebergTableFolder = temp3.newFolder();
-    File externalDataFilesTableFolder = temp4.newFolder();
-    File typeTestTableFolder = temp5.newFolder();
+    File partitionedFolder = temp.newFolder();
+    File unpartitionedFolder = temp.newFolder();
+    File newIcebergTableFolder = temp.newFolder();
+    File externalDataFilesTableFolder = temp.newFolder();
+    File typeTestTableFolder = temp.newFolder();
+    File vacuumTestTableFolder = temp.newFolder();
+    File logCleanTestTableFolder = temp.newFolder();
     partitionedLocation = partitionedFolder.toURI().toString();
     unpartitionedLocation = unpartitionedFolder.toURI().toString();
     newIcebergTableLocation = newIcebergTableFolder.toURI().toString();
     externalDataFilesTableLocation = 
externalDataFilesTableFolder.toURI().toString();
     typeTestTableLocation = typeTestTableFolder.toURI().toString();
+    vacuumTestTableLocation = vacuumTestTableFolder.toURI().toString();
+    logCleanTestTableLocation = logCleanTestTableFolder.toURI().toString();
 
     spark.sql(String.format("CREATE DATABASE IF NOT EXISTS %s", NAMESPACE));
 
     partitionedIdentifier = destName(defaultSparkCatalog, 
partitionedTableName);
     unpartitionedIdentifier = destName(defaultSparkCatalog, 
unpartitionedTableName);
     externalDataFilesIdentifier = destName(defaultSparkCatalog, 
externalDataFilesTableName);
     typeTestIdentifier = destName(defaultSparkCatalog, typeTestTableName);
+    vacuumTestIdentifier = destName(defaultSparkCatalog, vacuumTestTableName);
+    logCleanTestIdentifier = destName(defaultSparkCatalog, 
logCleanTestTableName);
 
     spark.sql(String.format("DROP TABLE IF EXISTS %s", partitionedIdentifier));
     spark.sql(String.format("DROP TABLE IF EXISTS %s", 
unpartitionedIdentifier));
     spark.sql(String.format("DROP TABLE IF EXISTS %s", 
externalDataFilesIdentifier));
     spark.sql(String.format("DROP TABLE IF EXISTS %s", typeTestIdentifier));
+    spark.sql(String.format("DROP TABLE IF EXISTS %s", vacuumTestIdentifier));

Review Comment:
   Instead of creating one subfolder for each table, I think we can just create 
tabes within the test, and do a `DROP DATABASE CASCADE` call in the end to 
remove all the tables after all tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org