JonasJ-ap commented on code in PR #6880: URL: https://github.com/apache/iceberg/pull/6880#discussion_r1117977829
########## delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java: ########## @@ -310,6 +351,11 @@ private DataFile buildDataFileFromAction(Action action, Table table) { FileFormat format = determineFileFormatFromPath(fullFilePath); InputFile file = deltaLakeFileIO.newInputFile(fullFilePath); + if (!file.exists()) { + throw new NotFoundException( + "The file %s does not exist in the Delta Lake table at %s", + fullFilePath, deltaTableLocation); Review Comment: I think checking file existence explicitly here can make the code logic more clear and have more reasonable error message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org