[GitHub] [iceberg] wypoon commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

[via GitHub]

wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1116504056


##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -226,7 +226,9 @@ public Snapshot apply() {
             manifestList,
             snapshotId(),
             parentSnapshotId,
-            sequenceNumber)) {
+            sequenceNumber,
+            ops.current().properties().get(TableProperties.AVRO_COMPRESSION),
+            
ops.current().propertyAsNullableInt(TableProperties.AVRO_COMPRESSION_LEVEL))) {

Review Comment:
   I changed `ops.current()` to `base` in the methods that I modified, but not 
in the other methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org