wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1116302161
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -162,6 +167,19 @@ public class TableTestBase {
static final FileIO FILE_IO = new TestTables.LocalFileIO();
+ // Mapping of Avro codec name used by Iceberg to name used by Avro (and
appearing in Avro metadata
+ // under the key, avro.codec).
+ // In tests, we use the Iceberg name to specify the codec, and we verify the
codec used by reading
+ // the Avro metadata and checking for the Avro name in avro.codec.
+ static final Map<String, String> AVRO_CODEC_NAME_MAPPING =
+ ImmutableMap.<String, String>builder()
+ .put(Avro.Codec.UNCOMPRESSED.name(), DataFileConstants.NULL_CODEC)
+ .put(Avro.Codec.ZSTD.name(), DataFileConstants.ZSTANDARD_CODEC)
+ .put(Avro.Codec.GZIP.name(), DataFileConstants.DEFLATE_CODEC)
+ .build();
+
+ static final long SNAPSHOT_ID = 987134631982734L;
Review Comment:
Hmm, I do not see any tests with `DUMMY_SNAPSHOT_ID`. The only occurrence of
`DUMMY_SNAPSHOT_ID` I found is as a private constant in `FlinkManifestUtil` for
`0L`.
I'll rename the `SNAPSHOT_ID` here to `EXAMPLE_SNAPSHOT_ID`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
