rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1112399818


##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -44,7 +44,7 @@ protected DataTableScan(
     this(table, schema, context);
   }
 
-  protected DataTableScan(Table table, Schema schema, TableScanContext 
context) {
+  public DataTableScan(Table table, Schema schema, TableScanContext context) {

Review Comment:
   I don't think that this should be public. If you need to have stats 
returned, then that option needs to be exposed through a public interface, not 
on the implementation class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to