rdblue commented on code in PR #6622: URL: https://github.com/apache/iceberg/pull/6622#discussion_r1112397085
########## api/src/main/java/org/apache/iceberg/expressions/MaxAggregate.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.expressions; + +import java.util.Comparator; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.types.Comparators; +import org.apache.iceberg.types.Conversions; +import org.apache.iceberg.types.Type.PrimitiveType; +import org.apache.iceberg.types.Types; + +public class MaxAggregate<T> extends ValueAggregate<T> { + private final int fieldId; + private final PrimitiveType type; + private final Comparator<T> comparator; + + protected MaxAggregate(BoundTerm<T> term) { + super(Operation.MAX, term); + Types.NestedField field = term.ref().field(); + this.fieldId = field.fieldId(); + this.type = field.type().asPrimitiveType(); + this.comparator = Comparators.forType(type); + } + + @Override + protected boolean hasValue(DataFile file) { + return file.upperBounds().containsKey(fieldId) + || (safeGet(file.valueCounts(), fieldId) != null Review Comment: I think this should be `&&`, not `||` to be careful about what is accepted. The upper bounds must have an entry for the field. But that entry could be `null` if the null count and the value count are equal. To be safe, I think this should be: ```java protected boolean hasValue(DataFile file) { boolean hasBound = file.upperBounds().containsKey(fieldId); Long valueCount = safeGet(file.valueCounts(), fieldId); Long nullCount = safeGet(file.valueCounts(), fieldId); boolean boundNonNull = valueCount != null && valueCount > 0 && nullCount != null && nullCount < valueCount; return hasBound && boundNonNull; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
