huaxingao commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1109427708
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##########
@@ -595,12 +593,12 @@ public void testNaN() {
explainContainsPushDownAggregates = true;
}
- Assert.assertTrue(
- "explain should contain the pushed down aggregates",
explainContainsPushDownAggregates);
+ Assert.assertFalse(
Review Comment:
I initially wanted to push down `NaN`, but I think it's better not to. I
changed to not push down if there are `NaN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
