[GitHub] [iceberg] wypoon commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

[via GitHub]

wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1106679819


##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -64,7 +69,7 @@ private ManifestWriter(PartitionSpec spec, OutputFile file, 
Long snapshotId) {
   protected abstract ManifestEntry<F> prepare(ManifestEntry<F> entry);
 
   protected abstract FileAppender<ManifestEntry<F>> newAppender(
-      PartitionSpec spec, OutputFile outputFile);
+      PartitionSpec spec, OutputFile outputFile, String compressionCodec, 
Integer compressionLevel);

Review Comment:
   If I do
   ```
     protected FileAppender<ManifestEntry<F>> newAppender(PartitionSpec spec, 
OutputFile outputFile) {
       return newAppender(spec, outputFile, null, null);
     }
   
     protected abstract FileAppender<ManifestEntry<F>> newAppender(
         PartitionSpec spec, OutputFile outputFile, String compressionCodec, 
Integer compressionLevel);
   ```
   I get
   ```
   > There were Java public API/ABI breaks reported by revapi:
     
     java.method.abstractMethodAdded: Abstract method was added.
     
     old: <none>
     new: method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>> 
org.apache.iceberg.ManifestWriter<F extends org.apache.iceberg.ContentFile<F 
extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,
 org.apache.iceberg.io.OutputFile, java.lang.String, java.lang.Integer)
     
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org