wypoon commented on PR #6799: URL: https://github.com/apache/iceberg/pull/6799#issuecomment-1426085222
I am picking up https://github.com/apache/iceberg/pull/5893 where @sumeetgajjar left off, as he is now pursuing other projects. @rdblue I believe Sumeet has addressed your feedback. Compression level is an Integer, to allow for it to be null (for codecs that do not use compression level), and I have used `PropertyUtil.propertyAsNullableInt` to turn the String into an Integer. Sumeet has removed unnecessary changes from tests and only added new tests. I have rebased Sumeet's changes on master, fixed some issues, and moved the Flink changes from 1.15 to 1.16 (the current default Flink version). This is ready for review. cc @nastra and @amogh-jahagirdar who reviewed the original PR as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
