JonasJ-ap commented on code in PR #6646:
URL: https://github.com/apache/iceberg/pull/6646#discussion_r1106265960


##########
python/pyiceberg/catalog/glue.py:
##########
@@ -461,8 +390,10 @@ def list_namespaces(self, namespace: Union[str, 
Identifier] = ()) -> List[Identi
             List[Identifier]: a List of namespace identifiers
         """
         # Glue does not support hierarchical namespace, therefore return an 
empty list
-        if namespace:
+        tuple_identifier = Catalog.identifier_to_tuple(namespace)
+        if len(tuple_identifier) > 1:

Review Comment:
   For example:
   If I run `pyiceberg list default`, now I will get all my databases:
   ```
   (pyiceberg-py3.9) (base) ➜  python git:(support-ddb-catalog) pyiceberg list 
default
   default                                   
   delta_lake_demo                           
   delta_playgrounddb                        
   hudi_playgrounddb                         
   migrate_delta_to_iceberg_demo             
   migrated_to_iceberg_demo                  
   mygluedatabase                            
   mygluedatabase2                           
   ...
   ```
   but previously I will get all my tables in `default` database:
   ```
   (pyiceberg-py3.9) (base) ➜  python git:(master) pyiceberg list default
   default.cloudtrail_logs_aws_cloudtrail_logs_481640105715_2dd430ba
   default.cloudtrail_logs_aws_cloudtrail_logs_481640105715_de0525cc
   default.table100                                                 
   default.test2                                                    
   default.test21                                                   
   default.test22                                                   
   default.test23                                                   
   default.test24                                                   
   default.test27                                                   
   default.test28                                                   
   default.test29                                                   
   default.test3     
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to