Fokko commented on code in PR #6646:
URL: https://github.com/apache/iceberg/pull/6646#discussion_r1104990604
##########
python/pyproject.toml:
##########
@@ -103,6 +103,7 @@ hive = ["thrift"]
s3fs = ["s3fs"]
glue = ["boto3"]
adlfs = ["adlfs"]
+dynamodb = ["boto3"]
Review Comment:
It doesn't seem to work at all:
```sh
➜ python git:(support-ddb-catalog) time pyiceberg --catalog dynamo list
∅
```
The hierarchical namespaces are just that you can have nested schemas:
`finance.debitors.invoices.unpaid`. The CLI will first check if there is a
nested namespace, and then if there are tables. For DynamoDB, you can just
check if there are multiple levels (more than one dot), and if this is the
case, just return an empty list:
```python
tuple_identifier = Catalog.identifier_to_tuple(identifier)
if len(tuple_identifier) > 1:
return []
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
