dramaticlly commented on code in PR #6797:
URL: https://github.com/apache/iceberg/pull/6797#discussion_r1106246951
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -120,9 +121,16 @@ public InternalRow[] call(InternalRow args) {
checkDuplicateFiles = args.getBoolean(3);
}
- long addedFilesCount =
- importToIceberg(tableIdent, sourceIdent, partitionFilter,
checkDuplicateFiles);
- return new InternalRow[] {newInternalRow(addedFilesCount)};
+ return importToIceberg(tableIdent, sourceIdent, partitionFilter,
checkDuplicateFiles);
+ }
+
+ private InternalRow[] toOutputRows(Snapshot snapshot) {
+ return new InternalRow[] {
Review Comment:
looks like checkstyle does not like my static import of member, I'll have a
temp var for summary
```
> Task :iceberg-spark:iceberg-spark-3.3_2.12:checkstyleMain
[ant:checkstyle] [ERROR]
/Users/stevezhang/workspace/iceberg/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:21:49:
Using a static member import should be avoided -
org.apache.iceberg.SnapshotSummary.ADDED_FILES_PROP. [AvoidStaticImport]
[ant:checkstyle] [ERROR]
/Users/stevezhang/workspace/iceberg/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:22:49:
Using a static member import should be avoided -
org.apache.iceberg.SnapshotSummary.CHANGED_PARTITION_COUNT_PROP.
[AvoidStaticImport]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
