RussellSpitzer commented on code in PR #6797:
URL: https://github.com/apache/iceberg/pull/6797#discussion_r1106193979
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -120,9 +121,16 @@ public InternalRow[] call(InternalRow args) {
checkDuplicateFiles = args.getBoolean(3);
}
- long addedFilesCount =
- importToIceberg(tableIdent, sourceIdent, partitionFilter,
checkDuplicateFiles);
- return new InternalRow[] {newInternalRow(addedFilesCount)};
+ return importToIceberg(tableIdent, sourceIdent, partitionFilter,
checkDuplicateFiles);
+ }
+
+ private InternalRow[] toOutputRows(Snapshot snapshot) {
+ return new InternalRow[] {
Review Comment:
I think you can beat the auto formatting messing up line 132 if you save
snapshot.summary() to a temp var like summary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
