jackye1995 commented on code in PR #5029:
URL: https://github.com/apache/iceberg/pull/5029#discussion_r1099074713
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -124,17 +126,27 @@ public void initializeState(FunctionInitializationContext
context) throws Except
if (context.isRestored()) {
LOG.info("Restoring state for the {}.", getClass().getSimpleName());
lastSnapshotId = lastSnapshotIdState.get().iterator().next();
- } else if (scanContext.startSnapshotId() != null) {
+ } else if (scanContext.startTag() != null || scanContext.startSnapshotId()
!= null) {
+ Preconditions.checkArgument(
+ !(scanContext.startTag() != null && scanContext.startSnapshotId() !=
null),
+ "START_SNAPSHOT_ID and START_TAG cannot be used both.");
Review Comment:
nit: cannot both be set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
