jackye1995 commented on code in PR #6637:
URL: https://github.com/apache/iceberg/pull/6637#discussion_r1095385434
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,14 +73,22 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
- | ALTER TABLE multipartIdentifier createReplaceBranchClause
#createOrReplaceBranch
+ | ALTER TABLE multipartIdentifier createReplaceBranchClause
#createOrReplaceBranch
+ | ALTER TABLE multipartIdentifier createTagClause
#createTag
+ ;
+
+createTagClause
+ : CREATE TAG (IF NOT EXISTS)? identifier tagOptions
;
createReplaceBranchClause
: (CREATE OR)? REPLACE BRANCH identifier branchOptions
| CREATE BRANCH (IF NOT EXISTS)? identifier branchOptions
;
+tagOptions
+ : (AS OF VERSION snapshotId)? (refRetain)?;
Review Comment:
hmm I just noticed this `;` in the end, also in `branchOptions`.
@amogh-jahagirdar is this required? It doesn't feel like required to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
