lirui-apache commented on code in PR #6698:
URL: https://github.com/apache/iceberg/pull/6698#discussion_r1092749767
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -119,6 +119,8 @@ private CatalogProperties() {}
"client.pool.cache.eviction-interval-ms";
public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(5);
+ /** Name of the custom {@link ClientPool} implementation class. */
+ public static final String CLIENT_POOL_IMPL = "client-pool-impl";
Review Comment:
Perhaps another way is to allow configurable cache keys? We can have
pre-defined key elements and users can use these elements to compose cache key
used in `CachedClientPool`. Some key elements I can think of: HMS URI (this is
probably mandatory), UGI, user name, specific configurations. When
`HiveCatalog` creates `CahcedClientPool`, it can check the configured key and
pass a key supplier to `CahcedClientPool`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
