rdblue commented on code in PR #6651: URL: https://github.com/apache/iceberg/pull/6651#discussion_r1085900334
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ########## @@ -304,4 +305,9 @@ public boolean caseSensitive() { .defaultValue(SQLConf.CASE_SENSITIVE().defaultValueString()) .parse(); } + + public String branch() { + return confParser.stringConf().option(SparkWriteOptions.BRANCH).defaultValue(SnapshotRef.MAIN_BRANCH).parse(); Review Comment: I think it would be nice to add a session config as well, which could be used to write to a branch in SQL. Then we could test DELETE FROM, MERGE INTO, UPDATE, and INSERT (OVERWRITE) queries as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org