amogh-jahagirdar commented on code in PR #6651: URL: https://github.com/apache/iceberg/pull/6651#discussion_r1084483714
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java: ########## @@ -304,4 +304,9 @@ public boolean caseSensitive() { .defaultValue(SQLConf.CASE_SENSITIVE().defaultValueString()) .parse(); } + + public String branch() { + return confParser.stringConf().option(SparkWriteOptions.BRANCH).parseOptional(); Review Comment: Can this return main if no branch is passed in? I think that will simplify some of the below logic a bit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org