jackye1995 commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1085895710
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -67,11 +69,15 @@ public boolean caseSensitive() {
}
public boolean localityEnabled() {
- if (table.io() instanceof HadoopFileIO) {
- HadoopInputFile file = (HadoopInputFile)
table.io().newInputFile(table.location());
- String scheme = file.getFileSystem().getScheme();
- boolean defaultValue = LOCALITY_WHITELIST_FS.contains(scheme);
- return PropertyUtil.propertyAsBoolean(readOptions,
SparkReadOptions.LOCALITY, defaultValue);
+ if (table.io() instanceof HadoopFileIO || table.io() instanceof
ResolvingFileIO) {
+ InputFile file = table.io().newInputFile(table.location());
+ if (file instanceof HadoopInputFile) {
+ String scheme = ((HadoopInputFile) file).getFileSystem().getScheme();
+ boolean defaultValue = LOCALITY_WHITELIST_FS.contains(scheme);
+ return PropertyUtil.propertyAsBoolean(readOptions,
SparkReadOptions.LOCALITY, defaultValue);
+ } else {
+ return false;
Review Comment:
I am fine with the current way since `.io()` is quite short. Up to you
Prashant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
