jackye1995 commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1095368618
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -168,6 +168,10 @@ private static String implFromLocation(String location) {
return SCHEME_TO_FILE_IO.getOrDefault(scheme(location), FALLBACK_IMPL);
}
+ public Class<? extends FileIO> ioClass(String location) {
+ return io(location).getClass();
Review Comment:
can we get the class from `implFromLocation` through
`Class.forName(className)`? `io()` will do the actual loading which is more
expensive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
