jackye1995 commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1085874242
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -82,6 +82,13 @@ snapshotRetentionClause
| WITH SNAPSHOT RETENTION numSnapshots SNAPSHOTS snapshotRetain
snapshotRetainTimeUnit
;
+createReplaceBranchClause
+ : (CREATE | REPLACE) BRANCH identifier branchOptions
+ ;
+
+branchOptions
+ : (AS OF VERSION snapshotId)? (RETAIN snapshotRefRetain
snapshotRefRetainTimeUnit)? (snapshotRetentionClause)?;
Review Comment:
I had a comment about simplifying the variables used in
https://github.com/apache/iceberg/pull/6637#discussion_r1083330622, could we
also follow that here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
