amogh-jahagirdar commented on code in PR #6637:
URL: https://github.com/apache/iceberg/pull/6637#discussion_r1083371736
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,7 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE TAG identifier (AS OF VERSION
snapshotId)? (RETAIN snapshotRefRetain snapshotRefRetainTimeUnit)? #createTag
Review Comment:
I think it make sense just to keep it separate as well. It's nice just to
read the sql extension and immediately see that CREATE TAG only supports RETAIN
(there's no notion of min snapshots to keep). Same principle applies with
CREATE BRANCH (can see what are the clauses that can be applied). Otherwise one
has to read the actual action logic to verify that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
