jackye1995 commented on code in PR #6634:
URL: https://github.com/apache/iceberg/pull/6634#discussion_r1083331843
##########
api/src/main/java/org/apache/iceberg/SnapshotUpdate.java:
##########
@@ -71,4 +71,8 @@ default ThisT toBranch(String branch) {
"Cannot commit to branch %s: %s does not support branch commits",
branch, this.getClass().getName()));
}
+
+ default String targetBranch() {
+ return SnapshotRef.MAIN_BRANCH;
+ }
Review Comment:
I think it's fine to keep it in the same PR if we need to add this API to
fix the logic, it makes the purpose more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
