amogh-jahagirdar commented on code in PR #6634:
URL: https://github.com/apache/iceberg/pull/6634#discussion_r1083324041
##########
core/src/test/java/org/apache/iceberg/TestTransaction.java:
##########
@@ -771,4 +771,14 @@ public void
testSimpleTransactionNotDeletingMetadataOnUnknownSate() throws IOExc
Assert.assertTrue("Manifest file should exist", new
File(manifests.get(0).path()).exists());
Assert.assertEquals("Should have 2 files in metadata", 2,
countAllMetadataFiles(tableDir));
}
+
+ @Test
+ public void testAppendTransactionMultipleBranches(){
+ Table table = load();
+ Transaction txn = table.newTransaction();
+ txn.newAppend().toBranch("b1").appendFile(FILE_A).toBranch("b1").commit();
+ txn.newAppend().toBranch("b2").appendFile(FILE_B).toBranch("b2").commit();
+ txn.newAppend().toBranch("b2").appendFile(FILE_C).toBranch("b2").commit();
+ txn.commitTransaction();
+ }
Review Comment:
Ignore this, was just playing around here. The bulk of this change will be
in the tests. I think for transactions we need to parameterize to test
transactions which commit to a single branch AND we need to have tests for
committing operations on different branches in a single transaction (which is
where things become more interesting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
