findepi commented on PR #6474: URL: https://github.com/apache/iceberg/pull/6474#issuecomment-1398101212
> Yes this is the consequence of different styles of the projects. That's a good point. I accept the inherent friction being result of that, but I do hope some of that friction is avoidable. > I like Trino's approach of checking null at every constructor and also use Optional as much as possible. I like it too. That's why I fully supported @kokosing's push for to leverage Optional whenever possible. There are still some rare places that would benefit from improvement, but we're generally in quite a good shape with null-unfriendliness. > For Iceberg, it would be ideal if nullability is at least indicated in documentation. 100% agreed, especially if you mean API-level documentation (javadoc, annotations), as that's what library users will see in their IDEs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
