nastra commented on code in PR #6586:
URL: https://github.com/apache/iceberg/pull/6586#discussion_r1082168946
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -132,6 +133,29 @@ public void testCreateTableBadName() {
TableIdentifier.of(namespace, "table-1"), schema,
partitionSpec));
}
+ @Test
+ public void testCreateAndLoadTableWithoutWarehouseLocation() {
+ GlueCatalog glueCatalogWithoutWarehouse = new GlueCatalog();
+ glueCatalogWithoutWarehouse.initialize(
+ catalogName,
+ null,
+ new AwsProperties(),
+ glue,
+ LockManagers.defaultLockManager(),
+ new S3FileIO(clientFactory::s3),
+ ImmutableMap.of());
+ String namespace = createNamespace();
+ String tableName = getRandomName();
+ TableIdentifier identifier = TableIdentifier.of(namespace, tableName);
+ try {
Review Comment:
nit: is the try-catch really needed when we expect the test to succeed? Or
is it more of a "give an additional hint when it fails"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
