jackye1995 commented on code in PR #6586:
URL: https://github.com/apache/iceberg/pull/6586#discussion_r1082151825
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -177,13 +178,9 @@ void initialize(
GlueClient client,
LockManager lock,
FileIO io) {
- Preconditions.checkArgument(
- path != null && path.length() > 0,
- "Cannot initialize GlueCatalog because warehousePath must not be null
or empty");
-
this.catalogName = name;
this.awsProperties = properties;
- this.warehousePath = LocationUtil.stripTrailingSlash(path);
+ this.warehousePath = path != null ? LocationUtil.stripTrailingSlash(path)
: null;
Review Comment:
good point, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
