RussellSpitzer commented on code in PR #6581: URL: https://github.com/apache/iceberg/pull/6581#discussion_r1072828083
########## core/src/main/java/org/apache/iceberg/actions/RemoveDanglingDeleteFilesActionResult.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import java.util.List; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; + +public class RemoveDanglingDeleteFilesActionResult implements RemoveDanglingDeleteFiles.Result { + + private static final RemoveDanglingDeleteFilesActionResult EMPTY = Review Comment: Do we really need this? Seems like in the code we can just add ```java new RemoveDanglingDeleteFileActionResult(Collections.emptyList()) ``` at https://github.com/apache/iceberg/pull/6581/files#diff-afa01360c6badf264da62497ccb1186cdd841cae290ab15b0a2b086cc100b9caR79 Doesn't seem like we really are making that many of these objects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
