rdblue commented on code in PR #2639: URL: https://github.com/apache/iceberg/pull/2639#discussion_r1071414198
########## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ########## @@ -1000,6 +1064,19 @@ public ReadBuilder withNameMapping(NameMapping newNameMapping) { return this; } + private FileDecryptionProperties createDecryptionProperties( + NativeFileCryptoParameters nativeParameters) { + Preconditions.checkArgument(nativeParameters != null, "Null native crypto parameters"); + + ByteBuffer footerDataKey = nativeParameters.fileKey(); + if (null == footerDataKey) { Review Comment: The "footer key" is used for the entire file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org