rdblue commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1103902520
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1000,6 +1042,21 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
return this;
}
+ public ReadBuilder withKeyMetadata(ByteBuffer encryptionKeyMetadata) {
Review Comment:
This is a ByteBuffer but the other was a class. That doesn't seem quite
right.
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1000,6 +1042,21 @@ public ReadBuilder withNameMapping(NameMapping
newNameMapping) {
return this;
}
+ public ReadBuilder withKeyMetadata(ByteBuffer encryptionKeyMetadata) {
+ if (encryptionKeyMetadata != null) {
Review Comment:
The other updates throw if there is a null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
