danielcweeks commented on code in PR #6352:
URL: https://github.com/apache/iceberg/pull/6352#discussion_r1055712976
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:
##########
@@ -74,17 +74,14 @@ class S3URI {
this.scheme = schemeSplit[0];
String[] authoritySplit = schemeSplit[1].split(PATH_DELIM, 2);
- ValidationException.check(
- authoritySplit.length == 2, "Invalid S3 URI, cannot determine bucket:
%s", location);
- ValidationException.check(
- !authoritySplit[1].trim().isEmpty(), "Invalid S3 URI, path is empty:
%s", location);
+
Review Comment:
Thanks for the context. I didn't realize this was possible via Athena or a
pattern anyone would use. I feel like we wouldn't recommend using a bucket as
the primary location, but since there is precedent and it would make it easier
to convert to Iceberg, supporting this makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
