szehon-ho commented on code in PR #6365: URL: https://github.com/apache/iceberg/pull/6365#discussion_r1054900975
########## core/src/main/java/org/apache/iceberg/AbstractTableScan.java: ########## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import org.apache.iceberg.events.Listeners; +import org.apache.iceberg.events.ScanEvent; +import org.apache.iceberg.expressions.ExpressionUtil; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.metrics.DefaultMetricsContext; +import org.apache.iceberg.metrics.ImmutableScanReport; +import org.apache.iceberg.metrics.ScanMetrics; +import org.apache.iceberg.metrics.ScanMetricsResult; +import org.apache.iceberg.metrics.ScanReport; +import org.apache.iceberg.metrics.Timer; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.types.TypeUtil; +import org.apache.iceberg.util.DateTimeUtil; +import org.apache.iceberg.util.SnapshotUtil; +import org.apache.iceberg.util.TableScanUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public abstract class AbstractTableScan<ThisT, T extends ScanTask, C extends ScanTaskGroup<T>> + extends BaseScan<ThisT, T, C> { + private static final Logger LOG = LoggerFactory.getLogger(AbstractTableScan.class); + private ScanMetrics scanMetrics; + + protected AbstractTableScan( + TableOperations ops, Table table, Schema schema, TableScanContext context) { + super(ops, table, schema, context); + } + + protected Long snapshotId() { + return context().snapshotId(); + } + + protected Map<String, String> options() { + return context().options(); + } + + protected abstract CloseableIterable<T> doPlanFiles(); + + protected ScanMetrics scanMetrics() { + if (scanMetrics == null) { + this.scanMetrics = ScanMetrics.of(new DefaultMetricsContext()); + } + + return scanMetrics; + } + + @Override + public Table table() { + return super.table(); + } + + public ThisT useSnapshot(long scanSnapshotId) { + Preconditions.checkArgument( + snapshotId() == null, "Cannot override snapshot, already set snapshot id=%s", snapshotId()); + Preconditions.checkArgument( + tableOps().current().snapshot(scanSnapshotId) != null, + "Cannot find snapshot with ID %s", + scanSnapshotId); + return newRefinedScan( + tableOps(), table(), tableSchema(), context().useSnapshotId(scanSnapshotId)); + } + + public ThisT useRef(String name) { + Preconditions.checkArgument( + snapshotId() == null, "Cannot override ref, already set snapshot id=%s", snapshotId()); + Snapshot snapshot = table().snapshot(name); + Preconditions.checkArgument(snapshot != null, "Cannot find ref %s", name); + return newRefinedScan( + tableOps(), table(), tableSchema(), context().useSnapshotId(snapshot.snapshotId())); + } + + public ThisT asOfTime(long timestampMillis) { + Preconditions.checkArgument( + snapshotId() == null, "Cannot override snapshot, already set snapshot id=%s", snapshotId()); + + return useSnapshot(SnapshotUtil.snapshotIdAsOfTime(table(), timestampMillis)); + } + + @Override + public CloseableIterable<T> planFiles() { + Snapshot snapshot = snapshot(); + if (snapshot != null) { + LOG.info( + "Scanning table {} snapshot {} created at {} with filter {}", + table(), + snapshot.snapshotId(), + DateTimeUtil.formatTimestampMillis(snapshot.timestampMillis()), + ExpressionUtil.toSanitizedString(filter())); + + Listeners.notifyAll(new ScanEvent(table().name(), snapshot.snapshotId(), filter(), schema())); + List<Integer> projectedFieldIds = Lists.newArrayList(TypeUtil.getProjectedIds(schema())); + List<String> projectedFieldNames = + projectedFieldIds.stream().map(schema()::findColumnName).collect(Collectors.toList()); + + Timer.Timed planningDuration = scanMetrics().totalPlanningDuration().start(); + + return CloseableIterable.whenComplete( + doPlanFiles(), + () -> { + planningDuration.stop(); + Map<String, String> metadata = Maps.newHashMap(context().options()); + metadata.putAll(EnvironmentContext.get()); + ScanReport scanReport = + ImmutableScanReport.builder() + .schemaId(schema().schemaId()) + .projectedFieldIds(projectedFieldIds) + .projectedFieldNames(projectedFieldNames) + .tableName(table().name()) + .snapshotId(snapshot.snapshotId()) + .filter(ExpressionUtil.sanitize(filter())) + .scanMetrics(ScanMetricsResult.fromScanMetrics(scanMetrics())) + .metadata(metadata) + .build(); + context().metricsReporter().report(scanReport); + }); + } else { Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
