aokolnychyi commented on code in PR #6365:
URL: https://github.com/apache/iceberg/pull/6365#discussion_r1053538261
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -361,6 +363,27 @@ private String errorMsg(String operation) {
return String.format("Operation %s is not supported after the table is
serialized", operation);
}
+ public static class SerializablePositionDeletesTable extends
SerializableTable {
+
+ private final String baseTableName;
+
+ protected SerializablePositionDeletesTable(PositionDeletesTable
deletesTable) {
+ super(deletesTable);
+ this.baseTableName = deletesTable.table().name();
+ }
+
+ @Override
+ protected Table newTable(TableOperations ops, String tableName) {
+ Table baseTable = new BaseTable(ops, baseTableName);
+ return new PositionDeletesTable(ops, baseTable, tableName);
+ }
+
+ @Override
+ public BatchScan newBatchScan() {
Review Comment:
Can't we override `newBatchScan()` in `SerializableTable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
