MurderWind commented on issue #6455:
URL: https://github.com/apache/iceberg/issues/6455#issuecomment-1360718909
> @MurderWind if you can reproduce it in IDE, you may be able to
troubleshoot it with debugger.
>
> `IcebergSource` should use a new thread pool
>
> ```
> public ContinuousSplitPlannerImpl(Table table, ScanContext scanContext,
String threadName) {
> this.table = table;
> this.scanContext = scanContext;
> this.isSharedPool = threadName == null;
> this.workerPool =
> isSharedPool
> ? ThreadPools.getWorkerPool()
> : ThreadPools.newWorkerPool(
> "iceberg-plan-worker-pool-" + threadName,
scanContext.planParallelism());
> }
> ```
>
> As the threadName is non-null passed in from `IcebergSource`
>
> ```
> // Ideally, operatorId should be used as the threadPoolName as Flink
guarantees its uniqueness
> // within a job. SplitEnumeratorContext doesn't expose the
OperatorCoordinator.Context, which
> // would contain the OperatorID. Need to discuss with Flink community
whether it is ok to expose
> // a public API like the protected method "OperatorCoordinator.Context
getCoordinatorContext()"
> // from SourceCoordinatorContext implementation. For now, <table
name>-<random UUID> is used as
> // the unique thread pool name.
> return lazyTable().name() + "-" + UUID.randomUUID();
> }
> ```
i found the issues .
` protected JdbcTableOperations(
JdbcClientPool dbConnPool,
FileIO fileIO,
String catalogName,
TableIdentifier tableIdentifier,
Map<String, String> catalogProperties) {
this.catalogName = catalogName;
this.tableIdentifier = tableIdentifier;
this.fileIO = fileIO;
this.connections = dbConnPool;
this.catalogProperties = catalogProperties;
}`
the dbConnPool has initialize. but
org.apache.iceberg.jdbc.JdbcCatalog#close this.closed =true . when
org.apache.iceberg.ClientPoolImpl#get
Preconditions.checkState(!this.closed, "Cannot get a client from a closed
pool");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
