rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053468991
##########
core/src/main/java/org/apache/iceberg/IncrementalFileCleanup.java:
##########
@@ -260,10 +260,18 @@ public void cleanFiles(TableMetadata beforeExpiration,
TableMetadata afterExpira
findFilesToDelete(manifestsToScan, manifestsToRevert, validIds,
afterExpiration);
deleteFiles(filesToDelete, "data");
- LOG.warn("Manifests to delete: {}", Joiner.on(",
").join(manifestsToDelete));
- LOG.warn("Manifests Lists to delete: {}", Joiner.on(",
").join(manifestListsToDelete));
+ LOG.debug("Manifests to delete: {}", Joiner.on(",
").join(manifestsToDelete));
Review Comment:
Joining should not be performed prior to passing the argument to debug, or
else it will always create a string regardless of whether it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
