rdblue commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1043912545


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -204,7 +204,11 @@ private TableMetadata internalApply() {
     base.snapshots().stream()
         .map(Snapshot::snapshotId)
         .filter(snapshot -> !idsToRetain.contains(snapshot))
-        .forEach(idsToRemove::add);
+        .forEach(
+            snapshotId -> {
+              updatedMetaBuilder.removeStatistics(snapshotId);

Review Comment:
   This should be handled inside of `removeSnapshots` because we 
`TableMetadata` that to maintain consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to