zhongyujiang commented on code in PR #6431:
URL: https://github.com/apache/iceberg/pull/6431#discussion_r1051751770
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java:
##########
@@ -360,6 +362,21 @@ public void testNotNaNs() {
Assert.assertTrue("Should read: no_nans column will contain non-NaN",
shouldRead);
}
+ @Test
+ public void testNotNaNOnNaNsAndNulls() {
+ boolean shouldRead =
+ new ParquetDictionaryRowGroupFilter(SCHEMA, isNull("_nans_and_nulls"))
Review Comment:
Added tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
