zhongyujiang commented on code in PR #6431:
URL: https://github.com/apache/iceberg/pull/6431#discussion_r1051750000
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java:
##########
@@ -165,20 +165,41 @@ public <T> Boolean isNaN(BoundReference<T> ref) {
}
Set<T> dictionary = dict(id, comparatorForNaNPredicate(ref));
- return dictionary.stream().anyMatch(NaNUtil::isNaN) ? ROWS_MIGHT_MATCH :
ROWS_CANNOT_MATCH;
+ return dictionary.contains(naNValueForType(ref.type()))
+ ? ROWS_MIGHT_MATCH
+ : ROWS_CANNOT_MATCH;
}
@Override
public <T> Boolean notNaN(BoundReference<T> ref) {
int id = ref.fieldId();
+ if (mayContainNulls.get(id)) {
Review Comment:
Okay, will remove the optimizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
