gaborkaszab commented on PR #6074: URL: https://github.com/apache/iceberg/pull/6074#issuecomment-1348180097
> This looks good to me other than a couple of small things to fix: > > * revapi suppressions are reordered, which is going to introduce churn > * It isn't clear why this wouldn't work with a create transaction Thanks for taking a look, @rdblue! 1: The revapi thing got solved after a rebase and re-doing the revapi changes. 2: I'm not sure I entirely get your comment with the 'create transaction' approach. Do you mean that I should create a transaction via Table.newTransaction() use it for do some stuff on the table and then in a next step do a Table.manageSnapshots(). I figured this would happen in 2 separate transaction then, one for the stuff going through the Transaction from Table.newTransaction() and then the stuff I do in the other Transaction from Table.manageSnapshot(). Do I get this wrong? What in fact I need is to do tasks from ManageSnapshots in the same transaction with other stuff through the Transaction interface (like updateProperties() in the same transaction with rollbackTo() in particular). **The motivation** here is kind of Impala vs HMS specific. When we are executing various `ALTER TABLE` statements on an Iceberg table we do it in a Transaction (things like expireSnapshots(), updateSchema() and others) but we observed that in the same Transaction we have to do an updateProperties() as well to set a new Catalog version. Doing this in the same transaction will generate a single Catalog event containing both changes, but in separate transactions this would generate multiple Catalog events where the catalog version update is in a separate event. Well, without going into even more Impala specific details this would cause us some headaches ([link](https://issues.apache.org/jira/browse/IMPALA-11508) for one such issue). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
